Add endpoints for Dexscreener support #422 #446
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@CapCap is attempting to deploy a commit to the Econia Labs Team on Vercel. A member of the Team first needs to authorize it. |
CapCap
force-pushed
the
capcap_dexscreener_api_stubs
branch
from
f8bcd40 to
73a45c7
Compare
CapCap
force-pushed
the
capcap_dexscreener_api_stubs
branch
2 times, most recently
from
baff241 to
b5de629
Compare
CapCap
force-pushed
the
capcap_dexscreener_api_stubs
branch
from
729df2f to
6cc3c00
Compare
CapCap
force-pushed
the
capcap_dexscreener_api_stubs
branch
from
6cc3c00 to
6a02e74
Compare
CapCap
force-pushed
the
capcap_dexscreener_api_stubs
branch
from
ed8703d to
36b8080
Compare
CapCap
force-pushed
the
capcap_dexscreener_api_stubs
branch
from
36b8080 to
1c168b2
Compare
There was a problem hiding this comment.
Noted how to use calculateCurvePrice to get the value of priceNative
Main thing to note is that it always returns the price in quote / base aka APT / emojicoin, which is what the comments you wrote seem to suggest Dexscreener expects...but just noting here that it doesn't change.
If asset0 and asset1 are always base / quote respectively, then this should be fine
xbtmatt
force-pushed
the
capcap_dexscreener_api_stubs
branch
from
26c10b7 to
ac4e38f
Compare
Dexscreener events cconverion v1 Dexscreener events cconverion v1 refac out of test Scope out other enddex points small lints Event feedback changes API mapping updates Add block and event index to API set fee bps use reserve calculation from SDK decimalize outputs fake block and event index add tests, ensure ID stability lint format
xbtmatt
force-pushed
the
capcap_dexscreener_api_stubs
branch
from
052c4b0 to
1cb0941
Compare
There was a problem hiding this comment.
Should be good to go now format/lint-wise, the only thing I noticed is that the types in the notion doc are actually different from the types in the dexscreener website API.
Specifically one thing is the lack of priceNative in the dexscreener repo API, but it's in the notion doc.
Is the notion doc more accurate/a more specific version you made with them? Just want to clarify before merging
xbtmatt
changed the title
Continuation of #422
Dexscreener API stubs
Dexscreener events cconverion v1
Dexscreener events cconverion v1
refac out of test
Scope out other enddex points
small lints
Event feedback changes
API mapping updates
Add block and event index to API
set fee bps
use reserve calculation from SDK
decimalize outputs
Description
Delete this sentence and add a description that explains what changes you have
done and why they were necessary.
Testing
Delete this sentence and provide a description of how to test the changes in
this PR.
Checklist